fwc commented on code in PR #56190: URL: https://github.com/apache/spark/pull/56190#discussion_r3457815865
########## sql/core/src/test/scala/org/apache/spark/sql/SessionQueryTest.scala: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import org.apache.spark.SparkFunSuite + +/** + * Provides connect-compatible test utils to write suites that have 'connect variants': + * {{{ + * // in sql/core + * FooSuite extends SessionQueryTest { test("") { ... } } + * + * // in sql/connect + * FooConnectSuite extends connect.SessionQueryTest + * }}} + * + * While this trait internally uses a [[classic.SparkSession]] when executing tests, + * it exposed as a [[SparkSession sql.SparkSession]] to allow for overriding on the connect side. + * + * For classic-specific tests, use [[classic.SessionQueryTest]]. + */ +trait SessionQueryTest + extends SparkFunSuite + with SessionQueryTestBase + with SparkSessionBinder { + + override def sessionType: String = "classic" Review Comment: I added `sessionType` since this pattern is already used in the classic/connect-agnostic tests here: https://github.com/apache/spark/blob/d76d7f5f6367518b4cb96b796a2c6ac83ec8303a/sql/core/src/test/scala/org/apache/spark/sql/connector/DSv2IncrementallyConstructedQueryTests.scala#L201-L232 > This seems to go against the spirit of writing session-agnostic tests. AkShUaLLy, diverging classic-/connect-semantics go against the spirit of writing session-agnostic tests. Having a `sessionType` here is a coping mechanism, and IMHO a good one. > The suggested test might be implemented cleaner as [classic- and connect-specific test, potentially with shared outlined logic] I strongly disagree here: When writing a test to document diverging classic/connect behaviour, that should be _a single testcase_. Your example would generally be in two different files, in two different modules (`sql/core` and `sql/connect/server`). Ofc it is generally possible to view two files side-by-side, but it still requires the linking of 'oh yeah, the second half of this test is somewhere over there'. (And outlining shared logic into `bar` violates my understanding of [DAMP, not DRY](https://abseil.io/resources/swe-book/html/ch12.html#tests_and_code_sharing_dampcomma_not_dr).) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
