ionagamed commented on code in PR #56190: URL: https://github.com/apache/spark/pull/56190#discussion_r3491364459
########## sql/core/src/test/scala/org/apache/spark/sql/classic/SessionQueryTest.scala: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.classic + +import org.apache.spark.sql + +/** + * Override of [[sql.SessionQueryTest]] that provides [[SparkSession classic.SparkSession]]. + * + * Can be used to declare classic-specific tests: + * {{{ + * class FooSuite extends sql.SessionQueryTest { + * // shared classic/connect-agnostic testcases + * } + * + * // no need to extend FooSuite as sql.SessionQueryTest + * // already executes shared tests via classic internally. + * class FooClassicSuite extends classic.SessionQueryTest { Review Comment: In a separate discussion with @fwc we've reached an agreement that the "DAMP, not DRY" way would probably to duplicate the required setup — it's either small enough to duplicate without issues, or big enough that it should be its own separate implementation that is callable by either test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
