fwc commented on code in PR #56190: URL: https://github.com/apache/spark/pull/56190#discussion_r3459950360
########## sql/core/src/test/scala/org/apache/spark/sql/SessionQueryTest.scala: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import org.apache.spark.SparkFunSuite + +/** + * Provides connect-compatible test utils to write suites that have 'connect variants': + * {{{ + * // in sql/core + * FooSuite extends SessionQueryTest { test("") { ... } } + * + * // in sql/connect + * FooConnectSuite extends connect.SessionQueryTest + * }}} + * + * While this trait internally uses a [[classic.SparkSession]] when executing tests, + * it exposed as a [[SparkSession sql.SparkSession]] to allow for overriding on the connect side. + * + * For classic-specific tests, use [[classic.SessionQueryTest]]. + */ +trait SessionQueryTest + extends SparkFunSuite + with SessionQueryTestBase + with SparkSessionBinder { + + override def sessionType: String = "classic" Review Comment: UPDATE: > If callers really want to know what type of session they have, they can use reflection while discussing with @ionagamed, we realized that ~reflection~ checking type info at runtime via e.g. `spark.isInstanceOf[connect.SparkSession]` doesn't really work now and would break even further when moving test definitons into `sql/tests`: Inside `sql/core`, we cannot see `connect.SparkSession`, so we can only as 'is this a classic session', which is IMHO kinda limiting. And when we move test definitions to some hypothetical `sql/tests` module that only sees `sql/api`, we can't even do that anymore. EDIT: I mixed up reflection and runtime type inspection, corrected accordingly. How would a `isConnect?` with reflection look like? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
