uros-b commented on code in PR #56664:
URL: https://github.com/apache/spark/pull/56664#discussion_r3462766433
##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala:
##########
@@ -510,7 +510,8 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
*/
override protected def handleUnknown(opt: String): Boolean = {
if (opt.startsWith("-")) {
- error(s"Unrecognized option '$opt'.")
Review Comment:
error() already exits with code 1. error() throws SparkException;
SparkSubmit.main -> doSubmit only catches SparkUserAppException, so the
SparkException propagates uncaught out of main and the JVM already terminates
with exit code 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
