arham0254A commented on PR #56664: URL: https://github.com/apache/spark/pull/56664#issuecomment-4784022364
Hi @uros-b, after testing the original codebase locally and tracing the exception path as you suggested, I confirmed that error() throws a SparkException which correctly remains uncaught by main. This results in the JVM inherently crashing and returning an OS exit code of 1. Since the original code already handles the exit code correctly at the JVM level, and my proposed change introduces a control-flow regression by breaking the exitFn test mocks, I am going to close this PR. I'll drop a note on SPARK-56539 to ask the reporter about their specific execution environment, as the 0 exit code they are seeing is likely being swallowed by an external wrapper. Thanks again for the detailed guidance and for taking the time to explain the test architecture! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
