uros-b commented on code in PR #56639:
URL: https://github.com/apache/spark/pull/56639#discussion_r3466114674
##########
sql/connect/server/src/test/scala/org/apache/spark/sql/connect/service/SparkConnectServiceInternalServerSuite.scala:
##########
@@ -261,6 +265,42 @@ class SparkConnectServiceInternalServerSuite extends
SparkFunSuite with LocalSpa
endEventSignal.acquire()
}
+ test("The SparkConnectService exposes standard gRPC health checks") {
Review Comment:
This test only asserts SERVING after start; does not verify the NOT_SERVING
transitions (pre-start, during/after stop()) that the description promises.
Adding a negative case would strengthen coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
