uros-b commented on code in PR #56639:
URL: https://github.com/apache/spark/pull/56639#discussion_r3466121346
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -472,6 +480,7 @@ object SparkConnectService extends Logging {
throw IllegalStateErrors.serviceNotStarted()
}
+ setHealthStatus(ServingStatus.NOT_SERVING)
Review Comment:
Consider `enterTerminalState()` instead of just setStatus(NOT_SERVING) on
shutdown. gRPC's recommended shutdown path is
healthStatusManager.enterTerminalState(), which permanently marks all services
NOT_SERVING and rejects further transitions. Nulling the field right after is
functionally OK since the server is being torn down, but enterTerminalState()
is the idiomatic cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
