uros-b commented on code in PR #56639:
URL: https://github.com/apache/spark/pull/56639#discussion_r3466128939
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectService.scala:
##########
@@ -488,6 +497,14 @@ object SparkConnectService extends Logging {
started = false
stopped = true
postSparkConnectServiceEnd()
+ healthStatusManager = null
Review Comment:
So stop() nulls `healthStatusManager`, but existing code never nulls
server/bindingAddress; and if startGRPCService() throws after the manager is
assigned, started stays false so a later stop() raises serviceNotStarted()
before reaching the cleanup? Cleanup seems a bit exception-unsafe / not
symmetric.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
