aokolnychyi commented on code in PR #56619: URL: https://github.com/apache/spark/pull/56619#discussion_r3477137188
########## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/txns.scala: ########## @@ -116,16 +116,10 @@ class TxnTable( // don't false-positive on the TxnTable wrapper having a different UUID. override val id: String = delegate.id - // The starting version should be the delegate version. - setVersion(delegate.version()) - - // Preserve column IDs from the delegate so that column ID validation can correctly detect - // drop-and-re-add scenarios (different IDs) and pass when columns are unchanged (same IDs). - // Uses assignMissingIds to keep the delegate's IDs for existing columns while assigning - // fresh IDs for any new columns added by schema evolution. - updateColumns(InMemoryBaseTable.assignMissingIds( - oldColumns = delegate.columns(), - newColumns = columns())) + // Column IDs for existing columns are preserved through the StructType round-trip via + // metadata encoding. assignMissingIds assigns fresh IDs to any new columns added by + // schema evolution. + updateColumns(InMemoryBaseTable.assignMissingIds(columns())) Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
