aokolnychyi commented on code in PR #56619:
URL: https://github.com/apache/spark/pull/56619#discussion_r3477448198
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala:
##########
@@ -77,10 +79,7 @@ class DataSourceV2DataFrameSuite
.set("spark.sql.catalog.mixedcolidcat",
classOf[MixedColumnIdTableCatalog].getName)
.set("spark.sql.catalog.mixedcolidcat.copyOnLoad", "true")
- .set("spark.sql.catalog.composedidcat",
- classOf[ComposedColumnIdTableCatalog].getName)
- .set("spark.sql.catalog.composedidcat.copyOnLoad", "true")
- .set(SQLConf.TIME_TYPE_ENABLED.key, "true")
+ .set(InMemoryBaseTable.ASSIGN_COLUMN_IDS, "true")
Review Comment:
Yeah, the idea to have this flag is to minimize the number of tests that
have to be modified to account for column IDs that didn't exist before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
