aokolnychyi commented on code in PR #56619:
URL: https://github.com/apache/spark/pull/56619#discussion_r3477933967
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala:
##########
@@ -2552,15 +2478,14 @@ class DataSourceV2DataFrameSuite
assert(typeAfter.toString.startsWith("StructType(StructField(age"),
s"age should be first field after reorder, got: $typeAfter")
- // Position-based keys: each ordinal position keeps its old ID after
- // reorder, so the composed string is unchanged despite the schema
change.
+ // The top-level column ID is preserved after reorder.
assert(idBefore == idAfter,
- s"Composed ID should be unchanged after reorder: $idBefore vs
$idAfter")
+ s"Top-level column ID should be unchanged after reorder: $idBefore vs
$idAfter")
}
}
- test("composed nested IDs tolerate nested field reorder end-to-end") {
- val t = "composedidcat.ns1.ns2.tbl"
+ test("nested field reorder does not trigger column ID mismatch") {
Review Comment:
Removed this test and replaced with a more appropriate one. It will be
tricky to implement reordering in the in-memory catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
