sunchao commented on code in PR #57016: URL: https://github.com/apache/spark/pull/57016#discussion_r3561393639
########## sql/connect/server/src/main/scala/org/apache/spark/status/api/v1/connect/ConnectResource.scala: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.status.api.v1.connect + +import jakarta.ws.rs._ +import jakarta.ws.rs.core.MediaType + +import org.apache.spark.sql.connect.ui.{ExecutionInfo, SessionInfo, SparkConnectServerAppStatusStore} +import org.apache.spark.status.api.v1.{BadParameterException, BaseAppResource, NotFoundException} + +@Produces(Array(MediaType.APPLICATION_JSON)) +private[v1] class ConnectResource extends BaseAppResource { + + @GET + @Path("sessions") + def sessionList( + @DefaultValue("0") @QueryParam("offset") offset: Int, + @DefaultValue("-1") @QueryParam("length") length: Int): Seq[SessionData] = withUI { ui => + val store = new SparkConnectServerAppStatusStore(ui.store.store) + val sessions = + if (length <= 0) store.getSessionList else store.getSessionList(offset, length) + sessions.map(prepareSessionData) + } + + @GET + @Path("sessions/{sessionId}") Review Comment: [P2] Preserve the full Connect session identity Spark Connect identifies sessions by `(userId, sessionId)`, and `SparkConnectServiceE2ESuite` explicitly supports two users sharing the same valid session UUID. This new route and the backing listener/KV record use only `sessionId`, so those sessions collapse: their execution counts merge, whichever user closes first finishes/removes the shared row while the other session remains valid, and History Server replay reproduces the same result. Please preserve the composite identity through the listener and KVStore, expose both components (or another unique opaque key) in the detail API, and add same-UUID/different-user live and replay coverage, including disk-store compatibility handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
