vaquarkhan commented on code in PR #57016: URL: https://github.com/apache/spark/pull/57016#discussion_r3534320971
########## sql/connect/server/src/main/scala/org/apache/spark/status/api/v1/connect/ConnectResource.scala: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.status.api.v1.connect + +import jakarta.ws.rs._ +import jakarta.ws.rs.core.MediaType + +import org.apache.spark.sql.connect.ui.{ExecutionInfo, SessionInfo, SparkConnectServerAppStatusStore} +import org.apache.spark.status.api.v1.{BaseAppResource, NotFoundException} + +@Produces(Array(MediaType.APPLICATION_JSON)) +private[v1] class ConnectResource extends BaseAppResource { + + @GET + @Path("sessions") + def sessionList( + @DefaultValue("0") @QueryParam("offset") offset: Int, + @DefaultValue("-1") @QueryParam("length") length: Int): Seq[SessionData] = withUI { ui => + val store = new SparkConnectServerAppStatusStore(ui.store.store) + paginate(store.getSessionList, offset, length).map(prepareSessionData) + } + + @GET + @Path("sessions/{sessionId}") + def session(@PathParam("sessionId") sessionId: String): SessionData = withUI { ui => + val store = new SparkConnectServerAppStatusStore(ui.store.store) + store + .getSession(sessionId) + .map(prepareSessionData) + .getOrElse(throw new NotFoundException("unknown session id: " + sessionId)) + } + + @GET + @Path("operations") + def operationList( + @DefaultValue("0") @QueryParam("offset") offset: Int, + @DefaultValue("-1") @QueryParam("length") length: Int): Seq[ExecutionData] = withUI { ui => + val store = new SparkConnectServerAppStatusStore(ui.store.store) + paginate(store.getExecutionList, offset, length).map(prepareExecutionData) + } + + // The operation id is a UUID and is therefore safe to use as a path segment, whereas the job + // tag embeds the raw user id (which may contain characters such as '/' that are not path-safe). + @GET + @Path("operations/{operationId}") + def operation(@PathParam("operationId") operationId: String): ExecutionData = withUI { ui => + val store = new SparkConnectServerAppStatusStore(ui.store.store) + store + .getExecutionByOperationId(operationId) + .map(prepareExecutionData) + .getOrElse(throw new NotFoundException("unknown operation id: " + operationId)) + } + + private def paginate[T](list: Seq[T], offset: Int, length: Int): Seq[T] = { + if (length < 0) list else list.slice(offset, offset + length) Review Comment: This slices after the caller has already materialized the whole store getSessionList/getExecutionList (lines 35 and 54) call KVUtils.viewToSeq(store.view(...)), loading all N rows on every request. So ?offset=0&length=10 still walks the entire store, and the default length=-1 (lines 33 and 52) means a bare GET /connect/operations returns an unbounded payload — an OOM/latency risk on a long-lived server. Please push offset/length into the KVStoreView (skip/max) and cap the default length. ########## sql/connect/server/src/main/scala/org/apache/spark/status/api/v1/connect/ConnectResource.scala: ########## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.status.api.v1.connect + +import jakarta.ws.rs._ +import jakarta.ws.rs.core.MediaType + +import org.apache.spark.sql.connect.ui.{ExecutionInfo, SessionInfo, SparkConnectServerAppStatusStore} +import org.apache.spark.status.api.v1.{BaseAppResource, NotFoundException} + +@Produces(Array(MediaType.APPLICATION_JSON)) +private[v1] class ConnectResource extends BaseAppResource { + + @GET + @Path("sessions") + def sessionList( + @DefaultValue("0") @QueryParam("offset") offset: Int, + @DefaultValue("-1") @QueryParam("length") length: Int): Seq[SessionData] = withUI { ui => + val store = new SparkConnectServerAppStatusStore(ui.store.store) + paginate(store.getSessionList, offset, length).map(prepareSessionData) + } + + @GET + @Path("sessions/{sessionId}") + def session(@PathParam("sessionId") sessionId: String): SessionData = withUI { ui => + val store = new SparkConnectServerAppStatusStore(ui.store.store) + store + .getSession(sessionId) + .map(prepareSessionData) + .getOrElse(throw new NotFoundException("unknown session id: " + sessionId)) + } + + @GET + @Path("operations") + def operationList( + @DefaultValue("0") @QueryParam("offset") offset: Int, + @DefaultValue("-1") @QueryParam("length") length: Int): Seq[ExecutionData] = withUI { ui => + val store = new SparkConnectServerAppStatusStore(ui.store.store) + paginate(store.getExecutionList, offset, length).map(prepareExecutionData) + } + + // The operation id is a UUID and is therefore safe to use as a path segment, whereas the job + // tag embeds the raw user id (which may contain characters such as '/' that are not path-safe). + @GET + @Path("operations/{operationId}") + def operation(@PathParam("operationId") operationId: String): ExecutionData = withUI { ui => + val store = new SparkConnectServerAppStatusStore(ui.store.store) + store + .getExecutionByOperationId(operationId) + .map(prepareExecutionData) + .getOrElse(throw new NotFoundException("unknown operation id: " + operationId)) + } + + private def paginate[T](list: Seq[T], offset: Int, length: Int): Seq[T] = { + if (length < 0) list else list.slice(offset, offset + length) Review Comment: This slices after the caller has already materialized the whole store getSessionList/getExecutionList (lines 35 and 54) call KVUtils.viewToSeq(store.view(...)), loading all N rows on every request. So ?offset=0&length=10 still walks the entire store, and the default length=-1 (lines 33 and 52) means a bare GET /connect/operations returns an unbounded payload an OOM/latency risk on a long-lived server. Please push offset/length into the KVStoreView (skip/max) and cap the default length. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
