wForget commented on code in PR #57073: URL: https://github.com/apache/spark/pull/57073#discussion_r3576622521
########## docs/sql-ref-syntax-qry-select-hints.md: ########## @@ -79,6 +84,10 @@ SELECT /*+ REBALANCE(c) */ * FROM t; SELECT /*+ REBALANCE(3, c) */ * FROM t; +SELECT /*+ REBALANCE_BY_SIZE(134217728) */ * FROM t; + +SELECT /*+ REBALANCE_BY_SIZE(134217728, c) */ * FROM t; Review Comment: Currently, the first argument to `REBALANCE_BY_SIZE` is optional. If we want to accept a string literal as the size, we would need to explicitly require the first argument to be the advisoryPartitionSize. Do you have any suggestions on how we could handle this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
