wForget commented on code in PR #57073: URL: https://github.com/apache/spark/pull/57073#discussion_r3576721779
########## docs/sql-ref-syntax-qry-select-hints.md: ########## @@ -79,6 +84,10 @@ SELECT /*+ REBALANCE(c) */ * FROM t; SELECT /*+ REBALANCE(3, c) */ * FROM t; +SELECT /*+ REBALANCE_BY_SIZE(134217728) */ * FROM t; + +SELECT /*+ REBALANCE_BY_SIZE(134217728, c) */ * FROM t; Review Comment: > In the current design, what's the difference between /*+ REBALANCE_BY_SIZE(c) */ and /*+ REBALANCE(c) */? There is no difference between them in the current design, this is only to maintain a consistent parameter style. > And what will be lost if we change the first arg advisoryPartitionSize from optional to required? I don't think we would lose anything. I also prefer a size literal parameter like 256m, so I’ll modify it that way.. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
