pan3793 commented on PR #57073:
URL: https://github.com/apache/spark/pull/57073#issuecomment-4966852357
Overall LGTM, two minor issues:
1. Test coverage gap in `ResolveHintsSuite.scala`
The existing `REBALANCE` hint has a test verifying it's silently ignored
when AQE is disabled. `REBALANCE_BY_SIZE` shares the same `if
conf.adaptiveExecutionEnabled` guard but lacks a corresponding test. Low risk
since the guard logic is identical, but the coverage is missing.
2. Docs/implementation mismatch
Docs only show string-literal examples (`REBALANCE_BY_SIZE('128m')`), but
the implementation also accepts numeric literals (`REBALANCE_BY_SIZE(2048)`,
`REBALANCE_BY_SIZE(4096L)`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
