nchammas commented on code in PR #57831:
URL: https://github.com/apache/spark/pull/57831#discussion_r3736549746
##########
common/utils/src/main/resources/error/error-conditions.json:
##########
@@ -4147,17 +4147,20 @@
"SESSION_CHANGED" : {
"message" : [
"The existing Spark server driver instance has restarted. Please
reconnect."
- ]
+ ],
+ "sqlState" : "08003"
},
"SESSION_CLOSED" : {
"message" : [
"Session was closed."
- ]
+ ],
+ "sqlState" : "08003"
},
"SESSION_NOT_FOUND" : {
"message" : [
"Session not found."
- ]
+ ],
+ "sqlState" : "08003"
}
},
"sqlState" : "HY000"
Review Comment:
I think it's weird -- and maybe even incorrect -- to have a sub-condition be
in a completely different error class than the parent condition. `HY` is for
"CLI-specific condition" and `08` is for "Connection Exception".
I know it's not something that this PR introduced, but I think the
sub-conditions under this condition should be broken up into at least two
separate conditions:
1. `08` class: `SESSION_*`
2. `HY` class: `FORMAT`, `OPERATION_*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
