pan3793 commented on code in PR #57831: URL: https://github.com/apache/spark/pull/57831#discussion_r3772953813
########## docs/sql-migration-guide.md: ########## @@ -24,6 +24,7 @@ license: | ## Upgrading from Spark SQL 4.3 to 4.4 +- Since Spark 4.4, the Spark Connect error conditions `INVALID_HANDLE.SESSION_CHANGED`, `INVALID_HANDLE.SESSION_CLOSED`, and `INVALID_HANDLE.SESSION_NOT_FOUND` are renamed to `SESSION_UNAVAILABLE.CHANGED`, `SESSION_UNAVAILABLE.CLOSED`, and `SESSION_UNAVAILABLE.NOT_FOUND`, and carry SQLSTATE `08003` (connection does not exist) instead of the generic `HY000`, so that clients detecting dead connections by SQLSTATE class `08` can recognize them. Code matching these errors should match the new condition names, or `08003` when matching on SQLSTATE. Spark Connect clients from earlier releases match the old names internally to detect a restarted server and to re-execute lost operations; against a Spark 4.4+ server those code paths no longer trigger, so upgrading such clients together with the server is recommended. Spark 4.4+ clients recognize both the old and the new names. Review Comment: I would like to land this in 4.3 or revert SPARK-57933 from 4.3 to avoid introducing tech debt. words sound too verbose, can you make it shorter? also applies to the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
