j1wonpark commented on PR #57831:
URL: https://github.com/apache/spark/pull/57831#issuecomment-5249212565
@dongjoon-hyun Thanks. This is now covered in #57887, in
`test_sqlstate_is_taken_from_the_main_class`. The snippet as written does not
reach `getSqlState()`: the constructor raises `ValueError: Cannot find sub
error class` while building the message template, so the case is pinned at the
reader level instead.
Worth a re-look there: since your approval I dropped the sub-condition
override on @nchammas's point, so `get_sqlstate` is now `split(".")[0]` and
never reads the sub-condition entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
