anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5341330947
Thanks for the review @cloud-fan , have addressed both points: added `hasNullInMultiColumnResult` (scanned via `rows.exists(_.anyNull)`, recomputed after broadcast deserialisation) and promote a `false` miss to `null` in both `eval` and `doGenCode`. Codegen falls back to the interpreted path since `InSet`'s generated `isNull` is the literal `false` in this case which is not assignable. Also replaced the count assertion with `checkAnswer` on actual null-padded rows, and added `withSQLConf` to bypass the optimizer's ExistenceJoin rewrite so the test actually exercises `InSubqueryExec`. Can you PTAL again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
