anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5381704607
Thanks for the detailed review @cloud-fan , have addressed all three: - Nondeterministic descendants (eg: rand() in LHS) now registered for partition-level init via a fresh index per append, mirroring CodegenFallback's exact pattern - lhsNullable now computed identically in both branches; legacy flag only gates rhsNullable - Non-null row index now built with TreeSet.newBuilder instead of foldLeft Added a legacy multi-column regression covering the nullable-LHS-field case the old formula got wrong. Can you PTAL again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
