anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5345616791
Thanks for the review @cloud-fan , replaced the coarse hasNullInMultiColumnResult global flag with a per-candidate three-valued comparison in evalMultiColumn: the inner loop short-circuits to FALSE on the first non-null field mismatch, sets UNKNOWN only when a null field is reached after all non-null fields matched and returns TRUE immediately on an exact match. The test fixture is updated to (99,99),(1,NULL) to cover both paths: (1,1) vs (99,NULL) → FALSE (first field differs); (1,1) vs (1,NULL) → UNKNOWN; (2,2) → TRUE (both candidates definitively unequal). Can you PTAL again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
