anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5406353514
Thanks for the review @cloud-fan , have addressed all five: - Reworded the RHS-nullability comment to describe a possible outcome, not unconditional - Clarified both "scan all result rows" comments to reflect the !hasUnknown early-exit that's already in the code - Removed the `BinaryType` copy-avoidance rationale for `inputFields` (LHS is a `GenericInternalRow` from `CreateNamedStruct`, so .get() doesn't copy) - Fixed the reversed null-pad labels in the first test's comment - Replaced Parquet-backed tables with VALUES-derived temp views in the non-head-nullability test, since Parquet file-source analysis applies `dataSchema.asNullable` and was silently defeating the test's nullability control Can you PTAL again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
