anshulbaliga7 commented on PR #58077: URL: https://github.com/apache/spark/pull/58077#issuecomment-5435441612
Thanks for the review @cloud-fan , have addressed all three: - Fixed the nullability comment to describe `UNKNOWN` as possible, not inevitable, when the LHS field is null - Cached `multiColNullRows/multiColNonNullSet` as locals (`nullRows/nonNullSet`) before the scan loops, avoiding repeated lazy-val accessor overhead per candidate - Added a codegen-enabled regression with rand() in a multi-column IN LHS to exercise the nondeterministic partition-initialization path end-to-end -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
