pan3793 commented on code in PR #58467:
URL: https://github.com/apache/spark/pull/58467#discussion_r3913794462
##########
core/src/main/scala/org/apache/spark/status/protobuf/KVStoreProtobufSerializer.scala:
##########
@@ -51,6 +54,14 @@ private[spark] object KVStoreProtobufSerializer {
}.toMap
}
- def getSerializer(klass: Class[_]): Option[ProtobufSerDe[Any]] =
- serializerMap.get(klass)
+ private[this] val missedClasses = ConcurrentHashMap.newKeySet[Class[_]]()
+
+ def getSerializer(klass: Class[_]): Option[ProtobufSerDe[Any]] = {
+ val serializer = serializerMap.get(klass)
+ if (serializer.isEmpty && missedClasses.add(klass)) {
+ logWarning(log"No Protobuf SerDe found for class ${MDC(CLASS_NAME,
klass.getName)}, " +
Review Comment:
it's intended to log it at the warning level: JSON is the default option,
and users likely switch to PROTOBUF for performance purposes, falling back
means a performance drop.
for noise concerns, it's a one-time warning that makes the gap visible
without flooding the log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
