pan3793 commented on code in PR #58467:
URL: https://github.com/apache/spark/pull/58467#discussion_r3915905853
##########
core/src/main/scala/org/apache/spark/status/protobuf/KVStoreProtobufSerializer.scala:
##########
@@ -51,6 +54,16 @@ private[spark] object KVStoreProtobufSerializer {
}.toMap
}
- def getSerializer(klass: Class[_]): Option[ProtobufSerDe[Any]] =
- serializerMap.get(klass)
+ private[this] val missedClasses = ConcurrentHashMap.newKeySet[Class[_]]()
+
+ private[protobuf] def resetMissedClassesForTesting(): Unit =
missedClasses.clear()
+
+ def getSerializer(klass: Class[_]): Option[ProtobufSerDe[Any]] = {
+ val serializer = serializerMap.get(klass)
+ if (serializer.isEmpty && missedClasses.add(klass)) {
Review Comment:
Partially done in 2b73e60: skipped
`RocksDB.TypeAliases`/`LevelDB.TypeAliases` - they are kvstore-library
internals the ProtobufSerDe SPI does not cover, so the warning is never
actionable there.
Kept the warning for `AppStatusStoreMetadata`/`FsHistoryProviderMetadata`:
SPARK-41053 scoped the SPIP to live UI, but SPARK-41685 (3.4.0) extended
protobuf to SHS, where stores are opened in batch - these classes benefit from
a serde and the warning flags them as real gaps, same as `LogInfo`. Will cover
them in a separate JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
