pan3793 commented on code in PR #58467:
URL: https://github.com/apache/spark/pull/58467#discussion_r3915094838
##########
core/src/main/scala/org/apache/spark/status/protobuf/KVStoreProtobufSerializer.scala:
##########
@@ -51,6 +54,14 @@ private[spark] object KVStoreProtobufSerializer {
}.toMap
}
- def getSerializer(klass: Class[_]): Option[ProtobufSerDe[Any]] =
- serializerMap.get(klass)
+ private[this] val missedClasses = ConcurrentHashMap.newKeySet[Class[_]]()
+
+ def getSerializer(klass: Class[_]): Option[ProtobufSerDe[Any]] = {
+ val serializer = serializerMap.get(klass)
+ if (serializer.isEmpty && missedClasses.add(klass)) {
Review Comment:
we started to experiment `spark.history.store.serializer=PROTOBUF` recently
and found that there are many fallbacks, even though the feature has been
developed since 3.4, so we want to expose them through warning logs to push us
(and the community) to fix those missing implementations incrementally.
for the current missed classes you pointed out, I think we should implement
protobuf serde for them shortly, then the warning logs will go away. and for
any future added beans without protobuf serde, a warning log will signal
developers to implement it.
so, I lean towards keeping it at the WARNING level, if you feel strongly, I
can lower it to INFO to keep it visible by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
