holdenk commented on code in PR #58696:
URL: https://github.com/apache/spark/pull/58696#discussion_r4078099746
##########
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala:
##########
@@ -231,6 +231,10 @@ private[rest] class StandaloneSubmitRequestServlet(
_.replace(s":$masterRestPort", s":$masterPort")).getOrElse(masterUrl)
val appArgs = Option(request.appArgs).getOrElse(Array[String]())
// Filter SPARK_LOCAL_(IP|HOSTNAME) environment variables from being set
on the remote system.
+ // Since SPARK-59404, RestSubmissionClient.filterSystemEnvironment already
drops these on the
+ // client side, so this filter is duplicated. It is kept for backward
compatibility with
+ // older clients and with requests that do not come from
RestSubmissionClient.
+ // TODO(SPARK-59669): Remove this duplicated filter in Spark 5.x.
Review Comment:
True, I reworeded the JIRA to unify the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
