dongjoon-hyun commented on PR #58696:
URL: https://github.com/apache/spark/pull/58696#issuecomment-5799561186
Thank you for the update, @holdenk. Targeting 4.3.0 is fine with me, so the
current `.version("4.3.0")` and the migration note in the 4.2-to-4.3 section
look right.
The latest head (f402b7d) still has three open review threads:
1. https://github.com/apache/spark/pull/58696#discussion_r4057909934: with
`spark.standalone.submit.filterEnvironment=false`, `SPARK_LOCAL_IP` /
`SPARK_LOCAL_HOSTNAME` are forwarded again. Could we always drop them and let
the flag control only the `SPARK_` prefix filtering?
2. https://github.com/apache/spark/pull/58696#discussion_r4057909940: the
JIRA was reworded, but the code comment still calls the server-side filter
"duplicated" and keeps `TODO(SPARK-59669)`. Could we remove the TODO and
describe it as the server-side check?
3. https://github.com/apache/spark/pull/58696#discussion_r4057909944: `new
SparkConf(false)` in `ClientSuite`, so a failure in `ClientEndpoint.onStart`
cannot `System.exit` the `core` test JVM.
Minor nits:
- `RestSubmissionClient.filterSystemEnvironment` is only called from
`org.apache.spark.deploy.Client`, so `private[deploy]` should be enough instead
of `private[spark]`.
- In the PR description, please use the `Generated-by: <tool> <version>`
form from `.github/PULL_REQUEST_TEMPLATE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
