dongjoon-hyun opened a new pull request, #873: URL: https://github.com/apache/spark-kubernetes-operator/pull/873
### What changes were proposed in this pull request? This PR deprecates the unused `resourceRetainPolicy` parameter of `ApplicationStatus.terminateOrRestart` and removes the dead code that handled it. - Add `terminateOrRestart(RestartConfig, String, boolean)` and make `AppCleanUpStep` use it. - Deprecate the 4-argument method, which now ignores `resourceRetainPolicy`. - Remove the unreachable retain-policy branches and the private `terminateAppWithoutReleaseResource`. ### Why are the changes needed? Since SPARK-59732 (#869), `AppCleanUpStep`, the only caller, always passes `ResourceRetainPolicy.Never`, so these branches never run. The method is deprecated instead of removed because `spark-operator-api` is a published module. ### Does this PR introduce _any_ user-facing change? No behavior change for the operator. The 4-argument `terminateOrRestart` is deprecated. ### How was this patch tested? Pass the CIs with the updated `ApplicationStatusTest`. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Opus 5.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
