brijrajk commented on PR #56174: URL: https://github.com/apache/spark/pull/56174#issuecomment-5837713364
To help answer @nchammas's question: the TODO comment in the current `master` at [functions.py:291](https://github.com/apache/spark/blob/master/python/pyspark/sql/protobuf/functions.py#L291) reads: ```python # TODO(SPARK-43847): Throw structured errors like "PROTOBUF_DESCRIPTOR_FILE_NOT_FOUND" etc. ``` So the intent to raise structured errors here was explicitly recorded when the function was written — this PR is implementing that TODO rather than introducing a new direction. That makes the "accident of history vs intentional choice" question a bit clearer: the absence was always meant to be temporary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
