nchammas commented on PR #56174: URL: https://github.com/apache/spark/pull/56174#issuecomment-5867302809
Oh right, the TODO (removed in this PR) answers the question of intent. And I take @HyukjinKwon's approval as confirmation that this is the right direction to go in. Unless @gaogaotiantian has any further concerns, I'll merge this in this week. @brijrajk - If you're interested in this area, it would make sense in a future PR to address the other file read failures like `PermissionError` and perhaps map them to a new `PROTOBUF_DESCRIPTOR_FILE_READ_FAILED` error condition specific to protobuf. (On the Scala side other read failures are currently mapped to `CANNOT_PARSE_PROTOBUF_DESCRIPTOR`, which I don't think is ideal.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
