srielau commented on code in PR #58549:
URL: https://github.com/apache/spark/pull/58549#discussion_r4109745291
##########
python/pyspark/sql/tests/arrow/test_arrow.py:
##########
@@ -1935,7 +1944,158 @@ def
test_toPandas_nested_array_with_map_empty_outer(self):
pandas_requirement_message or pyarrow_requirement_message,
)
class ArrowTests(ArrowTestsMixin, ReusedSQLTestCase):
- pass
+ # These CHAR/VARCHAR cases are Classic-only: they exercise
standard-semantics
Review Comment:
SPARK-59276 now supports Connect CHAR/VARCHAR transport, and this PR’s
widened Arrow mapper makes the pandas/PyArrow creation and `toArrow` paths
reachable there. Keeping the entire matrix in `ArrowTests` leaves those Connect
branches untested and makes the claim that Connect supports neither behavior
stale. Could we move the reusable standard/legacy cases into `ArrowTestsMixin`
or add focused Connect parity coverage, leaving only the RDD-threshold and
cached-schema UDT cases Classic-only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
