sarutak commented on PR #59185: URL: https://github.com/apache/spark/pull/59185#issuecomment-5934640143
Thanks for the review, @HyukjinKwon! Addressed all three nits. - Shared the RPC-encryption predicate between `UserCredentialManager` and `HadoopDelegationTokenManager` instead of duplicating it. - Fixed the scaladoc that mislabeled SASL encryption as AES-based. - Added negative tests for the encryption flags without `spark.authenticate`. On the local-mode point, I agreed, and thanks for confirming it matches the existing `HadoopDelegationTokenManager` behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
