sarutak commented on PR #59185:
URL: https://github.com/apache/spark/pull/59185#issuecomment-5947477473
Thank you, @dongjoon-hyun! I've addressed the followings.
1. Added `spark.security.oidc.requireRpcEncryption` (default `false`,
`version("4.4.0")`) next to the other `spark.security.oidc.*` entries.
2. Documented it in `docs/security.md`.
3. Added tests for `requireRpcEncryption=true`: startup fails without RPC
encryption and succeeds with it (same behavior in local mode, matching the
existing `require()`).
4. Moved the encryption check after the loader / token-file checks, so a
missing token file is reported directly. Added a test that pins this order (it
fails if the check moves back).
5. Used `SecurityManager.SSL_RPC_ENABLED_CONF` in the test instead of the
literal.
6. Made `rpcEncryptionRemediation` a `val`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
