sarutak commented on code in PR #59185:
URL: https://github.com/apache/spark/pull/59185#discussion_r4163340301
##########
core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala:
##########
@@ -79,10 +78,7 @@ private[spark] class HadoopDelegationTokenManager(
"Both principal and keytab must be defined, or neither.")
if (sparkConf.get(DIRECT_CREDENTIAL_PROVIDERS_ENABLED)) {
- val hasEncryption = sparkConf.getBoolean("spark.ssl.rpc.enabled", false) ||
- (sparkConf.get(NETWORK_AUTH_ENABLED) &&
- (sparkConf.get(NETWORK_CRYPTO_ENABLED) ||
sparkConf.get(SASL_ENCRYPTION_ENABLED)))
- require(hasEncryption,
+ require(UserCredentialManager.isRpcEncryptionEnabled(sparkConf),
Review Comment:
Addressed. The `require()` message is now built from the shared
`SecurityManager.rpcEncryptionRemediation`, the same source the OIDC warning
uses. So if `isRpcEncryptionEnabled` is extended later (e.g. a new
transport-encryption option), both the fail-fast message and the warning text
update from one place and stay consistent with what the predicate accepts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
