Nflrijal commented on PR #59089: URL: https://github.com/apache/spark/pull/59089#issuecomment-5970307648
Hi @HyukjinKwon, Thank you for the thorough review! I have updated the PR and rebased onto the latest `master`: 1. **X-Forwarded-Context absolute URL handling (`JettyUtils.scala`)**: Updated `addProxyHeaders` to extract the path component when `normalizedReverseProxyUrl` is an absolute URL (`http://` or `https://`), ensuring `X-Forwarded-Context` composition is safe when an outer proxy context is present. 2. **Local-mode ID support (`SparkContext.scala`)**: Added `/proxy/local-` check to `isAppSpecificProxyBase`. 3. **Unit Test Coverage**: Added test assertions for `SparkContext.stop()` property restoration (`SparkContextSuite`), as well as negative and deduplication branches for `Master._maybeAddReverseProxyConfig` (`MasterSuite`). All local unit tests and scalastyle pass 100% cleanly. Whenever you have a moment, please take another look. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
