Nflrijal commented on PR #59089:
URL: https://github.com/apache/spark/pull/59089#issuecomment-5975472018
Hi @HyukjinKwon ,
Thank you for the detailed feedback! I have updated the PR with additional
test coverage and rebased onto `master`:
1. **`SparkContext.scala` / `SparkContextSuite.scala`**: Added test
assertion verifying `spark.ui.proxyBase` is cleared on `SparkContext.stop()`
when no prior non-app-specific property was set (`test("SPARK-58893: clear
spark.ui.proxyBase property on stop when no prior property was set")`).
2. **`JettyUtils.scala` / `JettyUtilsSuite.scala`**: Added unit test
coverage for `addProxyHeaders` absolute path extraction and response `Location`
header rewriting (`test("SPARK-58893: reverse proxy addProxyHeaders and
filterServerResponseHeader rewriting")`).
3. **`MasterSuite.scala`**: Added test assertions for
`Master._maybeAddReverseProxyConfig` negative and deduplication branches.
All local unit tests and scalastyle pass 100% cleanly. Whenever you have a
moment, please take another look. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
