hemanthboyina commented on code in PR #59161:
URL: https://github.com/apache/spark/pull/59161#discussion_r4210470402
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/planmerging/MergeSubplansSuite.scala:
##########
@@ -1859,10 +1859,7 @@ class MergeSubplansSuite extends PlanTest {
}
}
- test("SPARK-56677: Do not merge subqueries when both join children have
independent filters") {
- // np has filters on BOTH left and right join children simultaneously. The
guard in the
- // Join case prevents this merge because combining two independent filter
attributes would
- // require ANDing them into a new alias, which is not yet supported.
+ test("SPARK-56677: Merge subqueries when both join children have independent
filters") {
Review Comment:
updated
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/planmerging/PlanMerger.scala:
##########
@@ -115,9 +115,7 @@ object PlanMerger {
* result of expressions like `coalesce(col, default)` in the aggregate: an
originally unmatched row
* would have contributed `default` via `coalesce(NULL, default)`, but in the
merged plan it is
* matched, its real column value fails the filter, and `FILTER (WHERE false)`
discards it entirely.
- * Propagation is also skipped when both the left and right children
simultaneously produce filter
- * attributes, as combining them would require an additional AND alias above
the join (not yet
- * supported).
+ * Filters from both join children are combined with AND above the join.
Review Comment:
sure, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
