hemanthboyina commented on code in PR #59161:
URL: https://github.com/apache/spark/pull/59161#discussion_r4210480039


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/planmerging/PlanMerger.scala:
##########
@@ -676,11 +674,7 @@ class PlanMerger(
               tryMergePlans(np.right, cp.right, context.copy(filterAboveScan = 
false)).flatMap {
                 case TryMergeResult(mergedRight, rightNPMapping, 
rightNPFilter, rightCPFilter, _,
                     rightDsv2Merged)
-                    // If both children independently propagate filter 
attributes we would need to
-                    // AND them into a new alias above the join, which is not 
yet supported.
-                    if !(leftNPFilter.isDefined && rightNPFilter.isDefined) &&
-                       !(leftCPFilter.isDefined && rightCPFilter.isDefined) &&
-                       // Gate join-crossing filter propagation behind its own 
config flag.
+                    if // Gate join-crossing filter propagation behind its own 
config flag.

Review Comment:
   added a leftOuter plan test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to