HyukjinKwon commented on PR #59316:
URL: https://github.com/apache/spark/pull/59316#issuecomment-6097270405
Thanks for the summary. No rebase is needed for review: the current head
(02b478e) is already a single commit on top of master (215a146). Items 1 and 2
don't seem to match that head, though. `CharVarcharUtils` has no
`applyXmlMapKeySemantics`, and `StaxXmlParser.convertXmlMapKey` still has the
inline CHAR/VARCHAR length checks rather than being a one-line call. Was a
later revision meant to be pushed? The tests from items 4 and 5 and the
scaladoc from item 7 are in the current head.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6093099179","thread_id":"conversation:6093099179","verdict_sha256":"e2711490564bf0952a2f15e7a9032d3dbc2d48dc5c1211da5ed6aaaa1a60f4b7"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
