srielau commented on PR #59316: URL: https://github.com/apache/spark/pull/59316#issuecomment-6104619249
@HyukjinKwon Thanks. The 4.3 baseline and flag-off CHAR overflow are corrected in the migration bullet and `convertMap` scaladoc (`38a81e3`). Flag-off coverage now asserts `EXCEED_LIMIT_LENGTH` for an over-length CHAR key. I also removed the dead SPARK-59274 `DUPLICATED_MAP_KEY` routing: `DuplicateMapKeyUtils`, the five `StaxXmlParser` arms, and the unused `assertDuplicateMapKey` helpers. Nothing on the XML parse path can raise that error after dropping `convertConstrainedMap`. On the view-flag question: I intend to keep session binding. `CHAR_VARCHAR_STANDARD_SEMANTICS` is `PERSISTED` so a view created under the flag keeps CHAR/VARCHAR types after resolution. CAST / `ToStringBase` still read `SQLConf.get` at runtime for pad vs length-check, and the XML parser matches that. Capturing the flag on `XmlToStructs` would be a broader CHAR/VARCHAR view-binding change; I would rather not do that in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
