srielau commented on PR #59316:
URL: https://github.com/apache/spark/pull/59316#issuecomment-6100927504
@HyukjinKwon Thanks for catching the stale follow-up. That comment described
an intermediate revision. After the squash, `convertXmlMapKey` is inlined in
`StaxXmlParser` and `CharVarcharUtils.applyXmlMapKeySemantics` is gone (items 1
and 2).
`8e1c55b` addresses the review on this thread:
- Struct-field maps go through `convertField` again, so empty,
attribute-only, and text-only `MAP<STRING, _>` elements stay SQL NULL or a
malformed record.
- `convertComplicatedType` only sends `MapType(_: StringType, _, _)`
(CHAR/VARCHAR included) to `convertMap`. `format("xml").load()` of `MAP<INT,
STRING>` stays a malformed record instead of `ClassCastException`.
- Prefixed-attribute and `valueTag` CHAR/VARCHAR checks use mixed content so
they still hit `convertMap`.
- `convertMap` scaladoc states the flag condition. The 4.3-to-4.4 migration
bullet now covers `attributePrefix` / `valueTag`, the 4.3 malformed-record
baseline, and that flag-off padding needs `preserveCharVarcharTypeInfo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
