dejankrak-db commented on code in PR #59305: URL: https://github.com/apache/spark/pull/59305#discussion_r4249510508
########## sql/api/src/main/scala/org/apache/spark/sql/types/FileType.scala: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.types + +import org.apache.spark.annotation.Unstable + +/** + * The data type representing a reference to an external file, such as a PDF, image, audio or + * video. A value holds the location of the file and a small amount of metadata describing it + * (size, content type and checksum); the bytes of the file are never stored in the value. + * + * In SQL the type is written `FILE EXTERNAL`, and its JSON representation is `"file"`. + * + * The type is physically represented as a struct but deliberately does not extend [[StructType]]. Review Comment: Thanks. The class comment now describes the struct layout and the map-key, grouping and clustering restrictions as planned for later parts, and says that this part only provides the DDL and JSON pieces (dda5841cfad and earlier commits on this branch). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
