brkyvz commented on code in PR #59305:
URL: https://github.com/apache/spark/pull/59305#discussion_r4266611868


##########
sql/api/src/main/scala/org/apache/spark/sql/types/DataType.scala:
##########
@@ -344,6 +345,16 @@ object DataType {
           TimestampNTZNanosType(p)
         }
       case "timestamp_ltz" => TimestampType
+      case FILE_TYPE(mode) =>
+        // Bare `"file"` resolves differently depending on context: inside a 
StructField it is
+        // an external file, which is also what a schema written without any 
metadata means; in a
+        // standalone parse (top-level `fromJson` or recursion outside any 
StructField) it has no
+        // mode yet, as when a UDF's return type is serialized as a bare 
`"file"`.

Review Comment:
   this feels a bit awkward. What if a UDF returns a nested type with a File in 
it? Don't we want to think that it is FILE unknown?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to