HyukjinKwon commented on PR #59422:
URL: https://github.com/apache/spark/pull/59422#issuecomment-6168809540
Yes, a small separate PR against `branch-4.0` is the way to go. Since
branch-4.0 keeps the old behavior, its doctest shouldn't just be switched to
`2`. It needs an example that gives the same result under both semantics. One
option is a pattern whose group 1 starts where the whole match starts, e.g.
`sf.lit(r'(\d+)(a|b|m)')` with idx `1`, which returns `1` both before and after
this change. Marking that output `# doctest: +SKIP` would also work.
SPARK-57348 handled the `sql_keywords` doctest the same way. It would be good
to land that PR before this one so the `pyspark-connect-old-client` job doesn't
go red on other PRs.
<!-- SPARK_DEV_REVIEW_REPLY
{"feedback_id":"conversation:6140310765","thread_id":"conversation:6140310765","verdict_sha256":"2ccc124865785dd93307b90b86713afac5a438bc77fba2852abef10d2469a03c"}
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
