HyukjinKwon commented on code in PR #59431:
URL: https://github.com/apache/spark/pull/59431#discussion_r4271915745
##########
.github/workflows/build_coverage.yml:
##########
@@ -49,3 +49,4 @@ jobs:
}
secrets:
codecov_token: ${{ secrets.CODECOV_TOKEN }}
+ DEVELOCITY_ACCESS_KEY: ${{ secrets.SPARK_DEVELOCITY_ACCESS_KEY }}
Review Comment:
**Non-blocking (P2):** This mapping key still uses the pre-rename name.
`build_and_test.yml` only declares `codecov_token` and
`SPARK_DEVELOCITY_ACCESS_KEY` under `on.workflow_call.secrets`, so GitHub
rejects this call ("Invalid secret, DEVELOCITY_ACCESS_KEY is not defined in the
referenced workflow"), and the scheduled coverage run, including its Codecov
upload, would stop starting after merge. Even if it were accepted, the called
jobs read `secrets.SPARK_DEVELOCITY_ACCESS_KEY` and would get an empty key.
Every other caller uses the declared name:
```suggestion
SPARK_DEVELOCITY_ACCESS_KEY: ${{ secrets.SPARK_DEVELOCITY_ACCESS_KEY }}
```
**Verification:**
- **Inspection:** Every secret name passed by each caller of the three
reusable workflows is declared under that workflow's on.workflow_call.secrets,
and the coverage caller maps SPARK_DEVELOCITY_ACCESS_KEY from
secrets.SPARK_DEVELOCITY_ACCESS_KEY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
