aleksandar-trajkovic-db opened a new pull request, #59634:
URL: https://github.com/apache/spark/pull/59634

   ### What changes were proposed in this pull request?
   
   3. Solution: `JdbcUtils.getSchema` and the private 
`JdbcUtils.getCatalystType` take `JDBCOptions` instead of the `isTimestampNTZ` 
and `preferTimestampNanos` booleans. `getSchema` still writes the same column 
metadata keys for dialects.
   
   ### Why are the changes needed?
   
   1. Goal: Read options that affect JDBC type mapping reach `getSchema` 
without widening its signature.
   2. Problem: Both callers, `JdbcUtils.getSchemaOption` and 
`JDBCRDD.getQueryOutputSchema`, already hold a `JDBCOptions` and unpack the 
same two fields from it. Each new option means another parameter plus an edit 
at both call sites.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing tests in `JDBCSuite` and `JDBCV2Suite`.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Anthropic Claude Opus 5.5)
   
   This pull request and its description were written by Isaac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to