aleksandar-trajkovic-db commented on code in PR #59634:
URL: https://github.com/apache/spark/pull/59634#discussion_r4323987676
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -304,18 +301,17 @@ object JdbcUtils extends Logging with SQLConfHelper {
/**
* Takes a [[ResultSet]] and returns its Catalyst schema.
*
+ * @param options The JDBC options of the read, which control how column
types are mapped.
* @param alwaysNullable If true, all the columns are nullable.
- * @param isTimestampNTZ If true, all timestamp columns are interpreted as
TIMESTAMP_NTZ.
* @return A [[StructType]] giving the Catalyst schema.
* @throws SQLException if the schema contains an unsupported type.
*/
def getSchema(
conn: Connection,
resultSet: ResultSet,
dialect: JdbcDialect,
- alwaysNullable: Boolean = false,
- isTimestampNTZ: Boolean = false,
- preferTimestampNanos: Boolean = false): StructType = {
+ options: JDBCOptions,
Review Comment:
Yes the conf you mention does exist, but it gets mapped to a JdbcOption:
https://github.com/apache/spark/blob/d36ebf3147fd79dcb159b9daa02743fc389b7b5b/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala#L269-L273
The option is intentionally dialect-agnostic, for the other dialects to be
able to use it in the future to remap their types to TimestampNTZ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
