aleksandar-trajkovic-db commented on code in PR #59634:
URL: https://github.com/apache/spark/pull/59634#discussion_r4323774438
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala:
##########
@@ -304,18 +301,17 @@ object JdbcUtils extends Logging with SQLConfHelper {
/**
* Takes a [[ResultSet]] and returns its Catalyst schema.
*
+ * @param options The JDBC options of the read, which control how column
types are mapped.
* @param alwaysNullable If true, all the columns are nullable.
- * @param isTimestampNTZ If true, all timestamp columns are interpreted as
TIMESTAMP_NTZ.
* @return A [[StructType]] giving the Catalyst schema.
* @throws SQLException if the schema contains an unsupported type.
*/
def getSchema(
conn: Connection,
resultSet: ResultSet,
dialect: JdbcDialect,
- alwaysNullable: Boolean = false,
- isTimestampNTZ: Boolean = false,
- preferTimestampNanos: Boolean = false): StructType = {
+ options: JDBCOptions,
Review Comment:
Everything inside JdbcUtils should be part of the internal API, so should
not require a release note. I am not sure I entirely understand the second
question. A JdbcOption already exists for Oracle's new TimestampNTZ (or for
that matter any dialect, as the option is dialect agnostic). It is currently
not propagated to getCatalystType, because that was too broad a change for a
single PR, but I think a follow up PR might be worth it for that. Right now, it
dictates the getter that gets picked during execution. Does that answer the
second question?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
